is this a common key binding? I've seen it before and it makes a lot of sense but I'm wondering if I will run into issues. I don't want to disrupt my flow and muscle memory and later regret it.
Unless you type a lot of graph algorithms notes (and have to write "Dijkstra"), you rarely encounter the key sequence jk. It makes it easier to work with vim and never move to hit the Esc key.
I use it and love it, even after binding Caps Lock to Esc.
The only issue I have is when I type something that ends with j or k and immediately want to exit insert mode. e.g. if I type "ack" and then mash jk to leave insert mode. Sometimes the j will hit first and only "ac" is left in the buffer.
That happens rarely though, and sometimes now I'll know it's going to happen and consciously type "ackkj" or just pause a beat to ensure the right thing happens.