I've found that culture is king in terms of governing what's shipped. From day 1 new hires are looking at what their peers are doing, and more importantly what's being tolerated by the manager and the rest of the team.
As an uninvited specific action recommendation: I've made it a habit to look through PR's (merged and unmerged) regularly. I point out opportunities for improvement, and more importantly I call out excellent solutions. The excellence can be in the form of elegance or just hard graft finding a bug. It's a small action that's additive and doesn't interrupt work. But it does wonders at setting the tone.
One thing I've found very hard indeed is if the team you manage is surrounded by peers that "don't give a fuck if what they do works or is of merchantable quality". However, if you reinforce your culture of excellence it becomes resilient to it ... and then the tricky thing becomes avoiding arrogance within the team.
>As an uninvited specific action recommendation: I've made it a habit to look through PR's (merged and unmerged) regularly.
If you did this in an environment with undercapacity, with the exception of being a very well respected or lead dev, I'd eventually call you out for being a snake trying to set the tone of development with nothing better to do. I had a colleague do this and its obnoxious. Especially because
I can see how that'd be weird for everyone to do it (unless they're themselves reviewing the PR). But in this context I am the engineering manager so it's my job to have oversight - so maybe that helps in my team?
One other bit that's probably worth mentioning is that I'm quick to point out when I've learnt something new from the PR in question. I guess I bundle that with "call out excellent solutions" - but it's a slightly different thing.
> is almost entirely subjective.
Of course. But even the regular discussion of what amounts to excellence helps move teams in that direction. What we're trying to get away from is "don't give a fuck if what they do works or is of merchantable quality" which exists in bucket-loads in giant corporations and I want my teams to have no part of it.
As an uninvited specific action recommendation: I've made it a habit to look through PR's (merged and unmerged) regularly. I point out opportunities for improvement, and more importantly I call out excellent solutions. The excellence can be in the form of elegance or just hard graft finding a bug. It's a small action that's additive and doesn't interrupt work. But it does wonders at setting the tone.
One thing I've found very hard indeed is if the team you manage is surrounded by peers that "don't give a fuck if what they do works or is of merchantable quality". However, if you reinforce your culture of excellence it becomes resilient to it ... and then the tricky thing becomes avoiding arrogance within the team.