Hacker News
new
|
past
|
comments
|
ask
|
show
|
jobs
|
submit
login
goosejuice
7 months ago
|
parent
|
context
|
favorite
| on:
The Theatre of Pull Requests and Code Review
I thought everyone did this. I review twice. For each commit with -v and finally in GH/GL after I open the PR/MR. I often catch something on that last one.
It's rubber ducking.
tcoff91
7 months ago
|
next
[–]
I self review but I don’t write comments. I simply fix the code as I see the problems that I find self reviewing.
jeffbee
7 months ago
|
prev
|
next
[–]
Unfortunately, these days, I am getting a lot of PRs where
nobody
has read the code, which came straight out of a robot. This makes me really angry.
manwe150
7 months ago
|
prev
[–]
What is `-v` mean here? I was assuming `git show`, but that doesn't seem to have a `-v` parameter.
ljosa
7 months ago
|
parent
[–]
`git commit` has a `-v` option that adds the diff to the bottom of the commit message template so you can see it while you write the message.
Consider applying for YC's Summer 2026 batch! Applications are open till May 4
Guidelines
|
FAQ
|
Lists
|
API
|
Security
|
Legal
|
Apply to YC
|
Contact
Search:
It's rubber ducking.