You're right about federation having failed in those instances, or at least failed to take over the world as was expected.

But Forgejo is a git + associated services application first and foremost. It's clearly on the up, and this federation is no more than a planned feature that may or may not catch on. You make it sound like Forgejo will fail because of it, but it's just an add-on.